kubeovn / kube-ovn / 27346061890

27%

push

github

fix(controller): skip service/endpointslice enqueueing when lb is disabled (#6859)

* fix(controller): skip service/endpointslice enqueueing when lb is disabled

The service/endpointslice informer handlers enqueue events
unconditionally, while all the queue consumers only start when
--enable-lb is set. With EnableLb disabled the queues accumulate
forever; updateServiceQueue and deleteServiceQueue hold pointer items
that never deduplicate, and each *vpcService pins the whole Service
object, so the controller leaks memory slowly on service churn.

Gate all the producers on EnableLb, keeping the EnableLbSvc branch in
enqueueAddService intact, and warn at startup when --enable-lb-svc is
set without --enable-lb since the feature cannot work in that case.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* fix(controller): gate lb svc enqueueing on enable-lb as well

The add service worker only starts when --enable-lb is set, so with
--enable-lb-svc set but --enable-lb disabled the addServiceQueue would
still accumulate without a consumer. Gate the producer on both flags,
matching the startup warning that the feature cannot work in that case.

Addresses the Copilot review note on PR #6859.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

---------

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

19 of 22 new or added lines in 3 files covered. (86.36%)

15111 of 57967 relevant lines covered (26.07%)

0.3 hits per line