supabase / cli / 27344309390
65%
develop: 65%

LAST BUILD BRANCH: gh-readonly-queue/develop/pr-5572-b899193b72da71ec461dc69ebfcd53eb7486194d
DEFAULT BRANCH: develop
Ran
Jobs 1
Files 224
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 64.676%. Remained the same
27344309390

push

github

web-flow 
fix(cli): preserve flag/env channel when delegating to the Go proxy (#5546)

## What changed

Ported legacy commands delegate to the bundled Go binary ("the proxy")
via `LegacyGoProxy.exec`. The proxy must be called **1:1 with the user's
input channel**: a value supplied as a CLI flag must reach the proxy as
a flag, and a value supplied as an environment variable must reach the
proxy as an environment variable. Neither should be cross-mapped.

`bootstrap` violated this for the DB password. It resolved the password
from `--password`, the `SUPABASE_DB_PASSWORD` env var, **or** an
interactive prompt, then always re-emitted it to the delegated `db push`
subprocess as a `--password` flag — mapping an env-sourced value onto a
flag.

## Why this is the correct mapping

In Go, bootstrap's `-p` flag is `BindPFlag`'d to viper `DB_PASSWORD`
(`cmd/bootstrap.go:67`); `create.Run` funnels the resolved value into
the same viper key (`create.go:31`); and `db push` reads it back via
`viper.GetString("DB_PASSWORD")` (`flags/db_url.go:128`). With
`SetEnvPrefix("SUPABASE") + AutomaticEnv()` (`root.go:320-322`), the
standalone `db push` subprocess resolves `DB_PASSWORD` from **either**
its own `-p` flag **or** the `SUPABASE_DB_PASSWORD` env var. So the
faithful mapping is flag→flag, env→env.

## Changes

- **`go-proxy.service.ts` / `go-proxy.layer.ts`** — add an optional
per-call `{ env }` overlay to `LegacyGoProxy.exec`, merged over the
construction-time env on top of the inherited process env (`extendEnv:
true`). Backward-compatible; all other call sites are unchanged.
- **`bootstrap.handler.ts`** (step L) — `--password` flag is forwarded
as `--password` (flag→flag); an env- or prompt-sourced password is
forwarded as the `SUPABASE_DB_PASSWORD` env var (env→env).
- **`bootstrap.integration.test.ts`** — the proxy mock now captures env;
the existing flag test asserts flag-only, plus two new tests cover the
env-source and prompt-source channels.
- **`SIDE_EFFECTS.md`** — do... (continued)

10528 of 16278 relevant lines covered (64.68%)

7.15 hits per line

Jobs
ID Job ID Ran Files Coverage
1 27344309390.1 224
64.68
 GitHub Action Run
Source Files on build 27344309390