databendlabs / openraft / 27335072378

87%

Build Type

push

github

Committed by drmingdrmer

Commit Message

refactor: add return value to MembershipState::commit()

# Summary

`MembershipState::commit()` now reports the transition of the committed
membership config: it returns the committed log ids before and after the
update, or `None` if nothing changes, so a caller can detect exactly when
a membership config becomes committed.

# Details

- The update happens only on an actual transition: if the effective
  membership is already committed, `commit()` is a no-op and returns
  `None`. Previously it re-assigned `self.committed` whenever
  `committed_log_id >= effective.log_id()`, including the equal case
  where the assignment had no effect.

- The doc comment is rewritten in terms of the `MembershipState` storage
  model: committing replaces `self.committed`(the membership state
  machine) with `self.effective`(the last membership log).

Coverage Stats

33 of 33 new or added lines in 2 files covered. (100.0%)

4 existing lines in 2 files now uncovered.

16298 of 18851 relevant lines covered (86.46%)

145738.48 hits per line