AfterShip / clickhouse-sql-parser / 27321031285

53%

master: 53%

Build Type

Pull #277

github

Committed by git-hulk

Commit Message

Rename lexer state to match what it holds

l.lastToken and p.last() actually hold the *current* lookahead token -
the one the parser is looking at but has not consumed - not a
previously-consumed token. Likewise l.current held the input byte
offset, not a token. Rename for accuracy, no behavior change:

- lexerState.current (int)    -> offset
- lexerState.lastToken        -> current
- Parser.last()               -> cur()
- Parser.lastTokenKind()      -> curTokenKind()
- Parser.lastTokenString()    -> curTokenString()
- local `lastToken` vars      -> curToken (parser files)

The one genuinely-previous token - the local in Lexer.consumeToken used
to disambiguate unary +/- - is named prevToken.

Also give TokenKindDot its missing TokenKind type annotation.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Pull Request Pull Request #277: Rename lexer state to match what it holds

Coverage Stats

160 of 231 new or added lines in 8 files covered. (69.26%)

1 existing line in 1 file now uncovered.

8364 of 16081 relevant lines covered (52.01%)

3001.37 hits per line