AfterShip / clickhouse-sql-parser / 27320812685

53%

master: 53%

Build Type

Pull #276

github

Committed by git-hulk

Commit Message

Add drift test keeping ASTVisitor and Walk traversals in sync

Accept/ASTVisitor and Walk/WalkFunc are two independent traversal
engines that encode every node's children separately, so a new AST node
type added to one can silently be missing from the other. Add a static
test that parses the package source and asserts every type with an
Accept method has both a Visit method on the ASTVisitor interface and a
case in Walk's type switch, and vice versa.

The test immediately caught four types missing from Walk - BoolLiteral,
CreateNamedCollection, NamedCollectionParam and WindowFrameParam - and
their cases are added.

Also fix a confirmed traversal bug: JoinTableExpr.Accept returned early
after visiting the sample ratio, so VisitJoinTableExpr was never called
for table expressions carrying a SAMPLE clause. Add a regression test.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Pull Request Pull Request #276: Add drift test keeping ASTVisitor and Walk traversals in sync

Coverage Stats

12 of 26 new or added lines in 2 files covered. (46.15%)

1 existing line in 1 file now uncovered.

8495 of 16105 relevant lines covered (52.75%)

2997.35 hits per line