cenkalti / rain / 27312094105

41%

Build Type

push

github

Committed by jakealti

Commit Message

refactor: modernize sorting with slices.SortFunc and builtin min

Replace sort.Slice/sort.Sort with slices.SortFunc (cmp.Compare/cmp.Or)
across piecepicker, unchoker, addrlist, magnet, and console, and use
slices.Sort for the string sort in jsonutil. Drop the redundant generic
min helper in piece (the Go 1.21 builtin covers both call sites).

addrlist's byTimestamp sort.Interface maintained a positional index in
its Swap method; since slices.SortFunc does not call Swap, re-index
explicitly after sorting and remove the now-dead type.

No behavior change: sort.Slice and slices.SortFunc are both unstable.

Coverage Stats

16 of 31 new or added lines in 7 files covered. (51.61%)

1 existing line in 1 file now uncovered.

4885 of 11953 relevant lines covered (40.87%)

46.84 hits per line