astronomer / astro-cli / da3d43cb-c911-42de-aa6b-ed0b01269573

45%

main: 44%

Build Type

Pull #2120

circleci

Committed by jlaneve

Commit Message

fix(env): round-trip Links/ExcludeLinks in update bodies

The platform treats Links/ExcludeLinks arrays omitted from a PATCH as
"remove them all" (while preserving omitted fields within a present link
entry). UpdateVar/UpdateAirflowVar/UpdateConn sent value-only bodies, so
`astro env variable update` silently unlinked the object from every
deployment, deleting any override the deployment had.

Extract the round-trip into echoLinksAndExcludes (nil-normalized to []
so the JSON carries empty arrays, not null), use it in the three update
functions and patchVarLinks, and fetch the full object on update instead
of just resolving the ID. Fix the LinkVar doc comment and link-create
help text that claimed the platform preserves omitted PATCH fields, with
the array-vs-field nuance spelled out. Regression test asserts a
value-only update echoes existing links and excludes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Pull Request Pull Request #2120: feat(env): add link / unlink / links commands for env variables

Coverage Stats

319 of 466 new or added lines in 10 files covered. (68.45%)

26 existing lines in 4 files now uncovered.

25341 of 56354 relevant lines covered (44.97%)

7.78 hits per line