Qiskit / qiskit-ibm-runtime / 27287313700

87%

main: 87%

push

github

Avoid options as property in WrapperEstimator (#2901)

<!--
⚠️ The pull request title should be short detailed and understandable
for all.
⚠️ Also, please add a release note file using reno if the change needs
to be
  documented in the release notes.
⚠️ If your pull request fixes an open issue, please link to the issue.

✅ I have added the tests to cover my changes.
✅ I have updated the documentation accordingly.
✅ I have read the CONTRIBUTING document.
-->

### Summary

Apply part of #2739 to `WrapperEstimator`, so it handles `options` in
the same way as the rest of "new" programs (instead of a decorator, uses
`__setattr__` for better auto-completing behavior and for more enforcing
of validation when the attribute is set, not only as part of
initializing during the constructor).

Tests have been copy-pasted (and adapted to use sampler / estimator
option classes). In the process an inconsistency arose related to
`experimental`, which defaults to a dict in `Executor` and allows `None`
in `Estimator` and `Sampler`. I favored Executor-style handling of it,
for consistency.

### Details and comments

Some tweaks of the docstrings in `option_models/` included.

Related to #2794 / #2681 

### AI/LLM disclosure

- [x] I didn't use LLM tooling, or only used it privately.

19 of 19 new or added lines in 8 files covered. (100.0%)

8030 of 9229 relevant lines covered (87.01%)

9.51 hits per line