stacklok / toolhive / 27285500883

67%

Build Type

push

github

Committed by web-flow

Commit Message

Move SDK hooks and two-phase session creation under Serve (#5471)

* Wire SDK hooks and session creation into Serve

Step P2.2 of the vMCP New/Serve split: the three mcp-go SDK hooks and the
two-phase session-creation wiring are SDK-lifecycle concerns that belong in
the transport layer, not the core VMCP domain object. This relocates them
into Serve so they execute identically when Serve is exercised directly.
server.New keeps its own copy until Phase 3, so its signature and observable
behavior are unchanged.

Implements changes for issue #5440:
- Register OnRegisterSession + OnBeforeListTools/OnBeforeCallTool hooks in
  Serve, delegating to the unchanged *Server receiver methods
- Build the transport session manager, session data storage (memory/Redis,
  THV_SESSION_REDIS_PASSWORD) with a close-on-error leak guard, and the vMCP
  session manager inside Serve
- Add ServerConfig.SessionManagerConfig (pre-built *sessionmanager.FactoryConfig)
  and the shared BackendRegistry; fold the now-redundant SessionFactory/
  OptimizerFactory/OptimizerConfig slots into FactoryConfig
- Add Serve-level tests driving the relocated hooks + two-phase creation via
  the SDK lifecycle, plus buildSessionDataStorage coverage; the HTTP suite
  stays on server.New as its parity gate

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Address code review feedback

Fixed issues from code review:
- HIGH: Split the t.Setenv redis case into its own non-parallel test and made
  TestBuildSessionDataStorage parallel, resolving the tparallel lint failure
- MEDIUM: Validate BackendRegistry in Serve (fail loudly with ErrInvalidConfig
  instead of nil-panicking inside the OnRegisterSession hook); add a
  nil-registry validation case and a testMinimalServeConfig helper
- MEDIUM: Document on SessionManagerConfig that the composition root must
  validate workflow definitions before assembling FactoryConfig, since Serve
  no longer runs validateWorkflows

Co-Authored-By... (continued)

Coverage Stats

56 of 60 new or added lines in 1 file covered. (93.33%)

14 existing lines in 5 files now uncovered.

67356 of 101558 relevant lines covered (66.32%)

62.75 hits per line