joaoh82 / rust_sqlite / 27271476638

70%

Build Type

push

github

Committed by web-flow

Commit Message

feat(sql): aggregates / GROUP BY / DISTINCT / HAVING over JOIN results (SQLR-6) (#164)

Generalize the SQLR-3 aggregation pipeline from (table, rowid) to the
RowScope trait, so the joined row stream feeds the same accumulator the
single-table path uses:

- aggregate_rows is now generic over an iterator of RowScopes; group
  keys and aggregate args resolve through scope.lookup, so NULL-padded
  outer-join rows group under NULL and COUNT(col) skips their NULLs.
- GROUP BY keys carry an optional t. qualifier (GROUP BY customers.name)
  via the new GroupByKey struct; AggregateArg::Column keeps its
  qualifier too (SUM(orders.amount)).
- The bare-column-must-be-in-GROUP-BY check stays in the parser for
  single-table queries and moves to the executor for joined ones, where
  qualifier resolution needs the schemas (resolve_scope_column).
- SELECT DISTINCT over a join dedupes the projected output rows, with
  LIMIT deferred past the dedupe (mirrors the single-table path).
- HAVING composes over joins through the shared
  lower_having_into_hidden_slots + run_aggregation_pipeline helpers.
- Bonus fix: SELECT * FROM t GROUP BY c used to panic on the
  'validated to be in GROUP BY' expect (parser validation skips
  Projection::All); it now surfaces the standard 'must appear in
  GROUP BY' error.
- Stale 'HAVING is not yet supported' error message and docs updated.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Coverage Stats

217 of 239 new or added lines in 3 files covered. (90.79%)

2 existing lines in 1 file now uncovered.

11762 of 16922 relevant lines covered (69.51%)

1.25 hits per line