kubeovn / kube-ovn / 27260952855

24%

master: 27%

Build Type

push

github

Committed by oilbeater

Commit Message

fix(controller): correct EIP v6 label update in SNAT/DNAT status patch (#6846)

In patchOvnSnatStatus the label replace branch assigned the IPv4 EIP
value to the EipV6IpLabel, and in patchOvnDnatStatus the replace branch
did not update EipV6IpLabel at all, leaving it stale. Both diverged
from their add branches. Also trigger the replace branch when only the
v6 EIP differs, so IPv6-only EIP changes are not missed.

A wrong v6 label breaks the webhook's isOvnEipInUse check, which lists
NAT rules by matching both EipV4IpLabel and EipV6IpLabel, allowing the
deletion of an OvnEip that is still referenced.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
(cherry picked from commit d8bde8605)

Coverage Stats

0 of 4 new or added lines in 2 files covered. (0.0%)

4 existing lines in 1 file now uncovered.

13343 of 54910 relevant lines covered (24.3%)

0.28 hits per line