kubeovn / kube-ovn / 27260111083

27%

Build Type

push

github

Committed by web-flow

Commit Message

fix(controller): avoid wiping priority-0 CNP map entries on zero-value key (#6844)

wipeCnpPriorityMapEntries deleted entries from the priority->name map of
both tiers using namePriorityMap[cnp.Name] as the key. When the CNP has
no entry in a tier's name->priority map (always true for the other tier,
and also for the CNP's own tier on first creation), the map read returns
the zero value int32(0), so delete(priorityNameMap, 0) silently removed
the entry of whatever CNP legitimately occupies priority 0 in that tier.

Since checkCnpPriorities relies on these maps as the only guard against
duplicate priorities within a tier, a second CNP could then be admitted
at priority 0, producing two CNPs with identical OVN ACL priorities and
undefined match ordering.

Guard the deletion with a comma-ok lookup so the priority->name entry is
only removed when the CNP actually has a mapping in that tier.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Coverage Stats

4 of 4 new or added lines in 1 file covered. (100.0%)

248 existing lines in 2 files now uncovered.

14985 of 57934 relevant lines covered (25.87%)

0.3 hits per line