AfterShip / clickhouse-sql-parser / 27258265881

52%

master: 52%

Pull #273

github

Fix nil-pointer dereference when formatting errors at EOF

Error messages built with `fmt.Errorf("... %q", p.last().String)` panic when
the lexer is at EOF, because `p.last()` is nil. Inputs like `ALTER `,
`SELECT*FROM A(0A` and `SET A=` triggered this.

Add a nil-safe `lastTokenString()` helper (mirroring `lastTokenKind()`) that
returns "<EOF>" when there is no current token, and use it in the 11 error
paths in parser_table.go and parser_alter.go. Success paths where last() is
provably non-nil are left untouched.

Add the inputs above to TestParser_InvalidSyntax to reproduce: they panicked
before the fix and now return a proper error.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

9 of 16 new or added lines in 3 files covered. (56.25%)

8291 of 16009 relevant lines covered (51.79%)

3014.6 hits per line