briandfoy / PerlPowerTools / 27250393534

63%

push

github

units: avoid division by zero (#1043)

* The code was too simple-minded because it assumed it was OK to proceed with division when a unit name is not recognised
* unit_convert() is called after an "unknown unit" error is printed, so just exit the program before delegating to unit_divide() which causes the division error
* In case $PARSE_ERROR is not set, don't bother printing it

Tests:
* "perl units cm ca" ---> arg2 unknown
* "perl units yo 0" ---> arg2 unknown

2 of 2 new or added lines in 1 file covered. (100.0%)

2070 of 3346 relevant lines covered (61.86%)

712.55 hits per line