stacklok / toolhive / 27240917404
67%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 751
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 66.283% (-0.004%) from 66.287%
27240917404

push

github

web-flow 
Fix operator ServiceAccount name consistency (#5476)

* Add failing custom-naming SA consistency test

Overriding operator.serviceAccount.name must keep the SA name consistent
across the created ServiceAccount, the Deployment's serviceAccountName,
and the role binding subjects. Today serviceaccount.yaml names the SA
from fullname and clusterrole/rolebinding.yaml hardcodes the subject, so
two of the four assertions fail. This commit captures the bug as a red
test; the template fix follows.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Route SA references through serviceAccountName helper

serviceaccount.yaml named the ServiceAccount from fullname, while
clusterrole/rolebinding.yaml hardcoded the subject and
leader-election-role.yaml used the raw serviceAccount.name. Overriding
operator.serviceAccount.name made these diverge: verified in a kind
cluster, the operator Deployment got zero pods ("error looking up
service account my-sa: serviceaccount not found").

Route all four references through the existing
toolhive-operator.serviceAccountName helper (use $ inside the rolebinding
range). This is a no-op on default values, where every reference already
resolves to toolhive-operator. Extend the custom-naming suite with the
empty-name fallback cases so the generated-name path is locked in too.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

67255 of 101467 relevant lines covered (66.28%)

63.36 hits per line

Coverage Regressions

Lines Coverage ∆ File
6
76.15
 -5.5% pkg/secrets/keyring/keyctl_linux.go
2
93.94
 -6.06% pkg/foreach/foreach.go
2
82.29
 -0.21% pkg/vmcp/composer/workflow_engine.go
Jobs
ID Job ID Ran Files Coverage
1 27240917404.1 751
66.28
 GitHub Action Run
Source Files on build 27240917404