kubeflow / trainer / 27233421640

63%

push

github

fix: apply clientConnection QPS/burst to the manager client (#3432)

* fix: Apply clientConnection QPS/burst to the manager's REST client

Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>

* chore: Regenerate Helm README for clientConnection values

Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>

* refactor: convert test cases from slices to maps per CONTRIBUTING.md convention

Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>

* fix: drop redundant default in Helm template and simplify smoke test

Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>

* fix: address review feedback - update ApplyClientConnection doc, drop redundant test, fractional QPS in values

Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>

* fix: adjust generated readme

Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>

* chore: run gofmt on config_test.go

Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>

* fix failing Helm e2e test PR check

Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>

---------

Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>

8 of 8 new or added lines in 1 file covered. (100.0%)

2212 of 3539 relevant lines covered (62.5%)

0.72 hits per line