0xmichalis / nftbk / 27233185475

48%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: move status types from strings to enums (#108)

* refactor: move status types from strings to enums

Define ArchiveStatus and IpfsStatus enums with serde snake_case
serialization (matching existing DB string values). Update BackupTask,
PinRow, Database trait, Db impl, workers, handlers, recovery module,
pruner, pin monitor, CLI, and all tests to use the new types instead
of raw strings.

No DB migration needed — enum serde produces the same strings:
- ArchiveStatus: in_progress, done, error, expired
- IpfsStatus: in_progress, done, error
- PinRow.pin_status uses existing PinResponseStatus enum

Closes #80

* fix: complete status enum migration to fix CI

Resolve compile, clippy, and fmt failures from the string->enum refactor:
- Import ArchiveStatus/IpfsStatus in test modules that use them; drop the
  now-unused top-level import in handle_backup_create
- Import IpfsStatus in handle_backup_delete_pins (used by the handler)
- Borrow statuses instead of moving out of &BackupTask in retry validation
- Pass status refs to validate_status_for_scope; use PinResponseStatus::Pinned
  literals instead of "pinned".into()
- Drop unused PinResponseStatus import and simplify and_then(|x| Ok(..)) to map
- Apply rustfmt

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(pin_monitor): map pin status via as_str instead of JSON round-trip

Addresses review feedback: serializing PinResponseStatus through serde_json
and falling back to unwrap_or_default() wrote an empty string to the DB on
any error and could panic in as_str().unwrap(). Add PinResponseStatus::as_str
(matching ArchiveStatus/IpfsStatus) and use it directly.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Hermes Agent <agent@hermes.ai>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

29 of 106 new or added lines in 12 files covered. (27.36%)

2 existing lines in 1 file now uncovered.

2360 of 4956 relevant lines covered (47.62%)

9.01 hits per line