stacklok / toolhive / 27228850861

67%

Build Type

push

github

Committed by web-flow

Commit Message

Add vMCP Serve skeleton and ServerConfig (#5467)

* Add vMCP Serve skeleton and ServerConfig

Introduce the transport-side entry point of the vMCP New/Serve split.
Serve wraps an already-constructed core VMCP and returns the existing
*Server, building the mcp-go server and applying the transport defaults
that server.New applies today. The route mux and HTTP lifecycle are
provided by the carried-forward Handler/Start/Stop, so observable
behavior is unchanged and server.New is not yet routed through Serve.

Implements changes for issue #5439:
- Add ServerConfig (transport-only fields plus the cross-cutting
  TelemetryProvider/AuditConfig) and Serve in pkg/vmcp/server/serve.go
- Validate nil cfg / nil core / nil SessionFactory via ErrInvalidConfig
- Wire the core's idempotent Close into the server shutdown sequence
- Guard the /status handler against a nil backend registry, which the
  transport does not own yet in this phase

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Address Serve skeleton review feedback

- Clarify the Serve doc comment: it builds only the mcp-go server and
  shutdown wiring; the route mux and HTTP lifecycle stay in the
  carried-forward Handler/Start until later phases relocate them
- Document the Config fields buildServeConfig deliberately leaves
  unmapped (AuthzMiddleware, HealthMonitorConfig) and why
- Add a reflection drift guard asserting every other Config field is
  populated by buildServeConfig, so a future field can't be dropped
  silently

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Tighten Serve skeleton per PR review

Addresses stacklok/toolhive#5467 review comments:
- MEDIUM serve.go (3381738359): extract shared default consts
  (defaultServerName/Version/Host/EndpointPath) referenced by New and
  buildServeConfig, and assert against them in tests, killing the
  triplicated literals
- MEDIUM serve.go (3381738361): drop the dead Config.StatusReporter
  mapping (set... (continued)

Coverage Stats

78 of 78 new or added lines in 3 files covered. (100.0%)

5 existing lines in 2 files now uncovered.

67232 of 101435 relevant lines covered (66.28%)

64.16 hits per line