topfreegames / pitaya / 27218689096

61%

master: 69%

Build Type

push

github

Committed by web-flow

Commit Message

fix(cluster): guard against nil Msg in NATS rpc server + bump nats.go to v1.52.0 (#502)

* fix(cluster): guard against nil Msg in NATS rpc server handleMessages

A payload delivered to a server's RPC subject that unmarshals into a
protos.Request without error but with a nil Msg caused handleMessages to
nil-panic at `req.Msg.Reply = msg.Reply`, crashing the whole process
(the goroutine has no recover). A well-formed pitaya RPC always sets Msg
(see buildRequest), so a nil Msg means the payload is malformed at the
source: an empty publish, a non-Request proto, or a schema-skewed sender
such as an older libpitaya client built against a different request.proto.

Drop such messages and log the surviving Request fields, the reply inbox,
and a capped hex prefix of the payload so the sender/route can be traced.

* chore(deps): bump nats.go to v1.52.0 (latest)

Updates github.com/nats-io/nats.go v1.39.0 => v1.52.0. v1.52.0 requires
go >= 1.25, so the module go directive is raised 1.23.0 => 1.25.0 and the
transitive deps it pulls (nkeys, klauspost/compress, golang.org/x/*) are
updated to match.

* ci: bump Go to 1.25 to match go.mod directive

The nats.go v1.52.0 bump raised the module go directive to 1.25.0, but CI
installed Go 1.24. The go.mod requirement then triggered a toolchain switch
during the coverage build, which surfaced as `go: no such tool "covdata"`.
Pin setup-go to 1.25 so the installed toolchain matches the directive.

Coverage Stats

1 of 13 new or added lines in 1 file covered. (7.69%)

20 existing lines in 3 files now uncovered.

5174 of 8458 relevant lines covered (61.17%)

0.67 hits per line