medplum / medplum / 27213179023

92%

push

github

fix(core): recreate WebSocket subscriptions on reconnect (#9447)

* fix(core): recreate WebSocket subscriptions on reconnect

The server drops the Subscription bound to a WebSocket connection when it closes,
but refreshAllSubscriptions preserved each criteria's subscriptionId across
reconnects, so rebindCriteriaEntry reused the now-deleted resource and
$get-ws-binding-token failed with the same dead id on every reconnect, forever —
the criteria stopped delivering until a full page reload.

Clear subscriptionId during refreshAllSubscriptions so rebindCriteriaEntry
recreates the Subscription on the new connection.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: d-vincent <d.mcdonald5227@gmail.com>

* fix(core): tolerate WebSocket error events without an `error` property

Browser WebSocket `error` events are bare `Event`s with no `.error`, so
`event.error.toString()` in the SubscriptionManager error handler throws a
`TypeError` on any socket error (and surfaces as an unhandled error during
reconnects under the test runner). Optional-chain the access.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: d-vincent <d.mcdonald5227@gmail.com>

* fix(core/ws): fallback to `event.message` when `.error` missing

Signed-off-by: Derrick Farris <derrick@medplum.com>

---------

Signed-off-by: d-vincent <d.mcdonald5227@gmail.com>
Signed-off-by: Derrick Farris <derrick@medplum.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Derrick Farris <derrick@medplum.com>

23338 of 26189 branches covered (89.11%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

36640 of 38929 relevant lines covered (94.12%)

23237.95 hits per line