databendlabs / openraft / 27203656165

87%

Build Type

push

github

Committed by drmingdrmer

Commit Message

change: replace EffectiveMembership with StoredMembership

# Summary

EffectiveMembership and StoredMembership both carried the same
(log_id, membership) record, and EffectiveMembership had degenerated into a
thin Arc<StoredMembership> wrapper. This consolidates everything onto
StoredMembership and removes EffectiveMembership together with its
EffectiveMembershipOf type-config alias entirely.

# Details

The wrapper's leftover voter_ids cache is dropped, and the items that were
unique to EffectiveMembership (new_arc, is_voter, learner_ids, get_node,
get_joint_config, and the QuorumSet impl) move onto StoredMembership so it
fully subsumes the wrapper. The struct and its bespoke
Default/Debug/PartialEq/Display impls are deleted, and the redundant double-Arc
in MembershipState collapses to a single Arc<StoredMembership>.

All openraft-internal code is migrated to StoredMembership / StoredMembershipOf,
and the public EffectiveMembership and EffectiveMembershipOf aliases are
removed.

User-visible: the effective/committed membership embedded in RaftMetrics now
renders via StoredMembership's formatting (Debug `StoredMembership { .. }`,
Display `{log_id:.., ..}`) instead of the old `EffectiveMembership{..}`; the
example metrics walkthroughs and the effective-membership doc page are updated
to match.

Also drops the unused public `From<(&LID, Membership)>` conversion that only
existed on the wrapper.

Upgrade tip:

Replace `EffectiveMembership` and `EffectiveMembershipOf<C>` with
`StoredMembership` and `StoredMembershipOf<C>`.

Coverage Stats

111 of 117 new or added lines in 25 files covered. (94.87%)

5 existing lines in 2 files now uncovered.

16281 of 18834 relevant lines covered (86.44%)

144853.2 hits per line