kubeovn / kube-ovn / 27194610094

24%

master: 27%

Build Type

push

github

Committed by oilbeater

Commit Message

fix(controller): avoid nil pointer panic in chassis and static route gc (#6835)

* fix(controller): avoid nil pointer panic in chassis and static route gc

gcChassis logged the ListChassis error but fell through to dereference
the nil result, panicking the whole controller process whenever the OVN
SB DB is briefly unreachable (libovsdb List runs an echo RPC and returns
ErrNotConnected during the disconnect/reconnect window). Return the error
like every other gc* function instead.

gcStaticRoute dereferenced route.Policy unconditionally, but policy is
optional in the OVN schema and may be nil for manually or third-party
created routes. Normalize an unset policy to the dst-ip default, matching
the convention used elsewhere in ovn-nb-logical_router_route.go.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* fix(controller): log normalized static route policy instead of raw pointer

Address Copilot review: the gc static route info/error logs printed
route.Policy (a pointer), showing an address or <nil> rather than the
normalized policy actually used for deletion. Log the resolved policy
value so GC behavior is easier to debug.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

---------

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
(cherry picked from commit bd2ffe6ee)

Coverage Stats

0 of 8 new or added lines in 1 file covered. (0.0%)

15 existing lines in 2 files now uncovered.

13268 of 54874 relevant lines covered (24.18%)

0.28 hits per line