Eyevinn / moqlivemock / 27166913508

50%

Build Type

push

github

Committed by tobbee

Commit Message

feat(mlmsub): refuse silent draft-14 downgrade over WebTransport

Over WebTransport the subscriber relied on the negotiated WT-Protocol subprotocol to pick the MoQ version. If a draft-16 peer omitted the WT-Protocol response header, the session silently fell back to offering only draft-14 in-band, which mis-negotiates against a draft-16-only server.

Record the offered protocol on the handler (Handler.Protocols) and pass it to the session (Session.Protocols) so it refuses to downgrade when the peer returns no WT-Protocol and we offered only draft-16+. Requires a moqtransport that provides Session.Protocols.

Refs facebookexperimental/moxygen#173.

Coverage Stats

1 of 3 new or added lines in 2 files covered. (33.33%)

5 existing lines in 1 file now uncovered.

2777 of 5592 relevant lines covered (49.66%)

959.5 hits per line