stacklok / toolhive / 27147463698

67%

Build Type

push

github

Committed by web-flow

Commit Message

Implement stateless core VMCP constructor (#5457)

* Implement stateless core VMCP constructor

Relocate the domain wiring buried in server.New (telemetry decoration,
workflow auditor, in-memory state store + workflow engine, per-session
composer factory, fail-fast workflow validation) into a working
New(cfg) (VMCP, error) in pkg/vmcp/core, turning the #5434 contract into
an identity-parameterized core that aggregates capabilities, routes
calls, and drives composite workflows.

Implements #5437:
- All ten VMCP methods on *coreVMCP. The core is stateless w.r.t.
  sessions: List/Lookup/Call health-filter the registry and aggregate on
  demand, then route through a per-call SessionRouter bound to the fresh
  routing table (removing context-injected capability coupling). "The
  core filters, Serve caches."
- Injected health.StatusProvider drives filterHealthyBackends before
  aggregation, preserving today's exact include/exclude rules (copied
  from discovery/middleware.go; temporary C2 duplication until Phase 3).
- Composite tools are advertised in ListTools (decorators may only
  subtract) and executed in CallTool via the relocated per-session
  composer pattern.
- Close() stops the state store cleanup goroutine and is idempotent.
- Relocate the backend-client telemetry decorator to
  pkg/vmcp/internal/backendtelemetry so server and core share it without
  an import cycle; server.New behavior is unchanged.

Identity is an explicit *auth.Identity on every method, never read from
context and never logged. The Cedar admission seam (#5438) is not wired
here.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Address code review feedback

Fixed issues from code review:
- HIGH: ReadResource/GetPrompt now pass the advertised name straight to
  the backend client (which owns the single name translation), matching
  CallTool and removing the fragile reliance on idempotent re-translation
- MEDIUM: add TestCallTool_ResolvesRenamedTool (dot-co... (continued)

Coverage Stats

285 of 327 new or added lines in 4 files covered. (87.16%)

4 existing lines in 2 files now uncovered.

67009 of 101197 relevant lines covered (66.22%)

63.97 hits per line