dangernoodle-io / breadboard / 27145557140

100%

push

github

fix(bb_http): persist route descriptors past init to stop 405-walk crash (#368)

- root cause: four init functions (bb_power_routes, bb_fan_routes x2,
  bb_thermal) copied a static-const template into a stack-local bb_route_t,
  wired .handler, then passed &local to bb_http_register_described_route;
  s_registry[] stores the pointer, so after init returns the entry dangles
- crash path: any HTTP request hitting the 405 handler calls
  bb_http_uri_is_registered, which walks s_registry[] and dereferences
  r->path on the stale pointer → LoadProhibited on tdongle-s3
- fix: promote each working copy to function-static storage so the pointer
  stored in the registry is valid for the process lifetime; adds negligible
  bss since each init runs exactly once at boot
- contract: strengthen registry_add comment to document that callers must
  pass descriptors with static/persistent storage duration
- test: add regression test asserting is_registered returns true for the
  registered path and false for an unregistered path, and that foreach
  yields a readable .path field (asan/valgrind catches stale reads here
  before they reach the device)

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

1604 of 1604 branches covered (100.0%)

Branch coverage included in aggregate %.

2702 of 2702 relevant lines covered (100.0%)

964.97 hits per line