sgerrand / ex_companies_house / 27136489953

100%

push

github

refactor: simplify facade config and route through Client seam (#92)

* refactor: route facade through Client seam

The CompaniesHouse facade reached the HTTP layer via its own
http_client/0 — a second Application.compile_env read of :http_client
that duplicated the defdelegate seam already defined in
CompaniesHouse.Client. Call Client.get/... directly and drop the
private indirection so there is one delegation point.

Also bind start_index + length(items) once (next_index) in
stream_paginated instead of traversing the list twice, and document
the single-seam convention in CLAUDE.md.

* refactor(config): fetch one key via get_env

get/2 built the full application env keyword list with
Application.get_all_env/1 then searched it with Keyword.get/3.
Application.get_env/3 fetches the single key directly.

15 of 15 new or added lines in 2 files covered. (100.0%)

90 of 90 relevant lines covered (100.0%)

6.73 hits per line