nbari / backup / 27130690190

80%

main: 80%

Build Type

push

github

Committed by nbari

Commit Message

run: interrupted-run safety (version completion flag) + fix orphan blob reuse

Two fixes for the cancel/re-run scenario:

- Correctness: LocalStore.put now OVERWRITES (atomic temp+rename) instead of
  skipping when the object exists. An interrupted run can leave an orphan blob
  (no Files row) encrypted with a now-lost key; since dedup is gated by the
  catalog (is_stored), put is only called for content that must be (re)written,
  so a re-run re-keys and overwrites it — the stored blob always matches the
  recorded key. (Previously the stale orphan was kept -> restore would fail.)

- Completion flag: BackupVersions gains completed_at, stamped in the same
  transaction as the metadata write (so complete == metadata committed AND all
  blobs stored, since uploads run first). latest_version() returns only completed
  versions, so view shows the last completed snapshot and ignores an interrupted
  one (clear 'no completed snapshot yet' message). Idempotent ALTER+backfill
  migration for existing catalogs.

Tests: orphan-overwrite e2e, latest_version completeness, put overwrite; manual
cancel/re-run smoke verified. 70 tests passing.

Coverage Stats

89 of 107 new or added lines in 4 files covered. (83.18%)

150 existing lines in 6 files now uncovered.

2759 of 3512 relevant lines covered (78.56%)

7.6 hits per line