Eyevinn / moqtransport / 27121732309

52%

Build Type

push

github

Committed by tobbee

Commit Message

feat(session): refuse silent draft-14 downgrade over WebTransport

When a WebTransport client offered only draft-16+ subprotocols and the peer returns no WT-Protocol response header, the version was left unset and CLIENT_SETUP silently fell back to offering only draft-14 in-band. Against a draft-16-only server this mis-negotiates and (before the prior commit) could hang.

Add a Protocols field recording the application protocols the caller offered. In RunContext, when the transport is WebTransport, no subprotocol was negotiated, and no offered protocol supports in-band negotiation (i.e. all are draft-16+), return an error instead of downgrading. Empty Protocols preserves the historical behavior, so this is opt-in for callers that set it.

Refs facebookexperimental/moxygen#173.

Coverage Stats

20 of 20 new or added lines in 1 file covered. (100.0%)

319 existing lines in 1 file now uncovered.

2818 of 5546 relevant lines covered (50.81%)

5.6 hits per line