code-shoily / choreo / c3f536810f600f4adb8205d0009155ba492b1330

88%

push

github

fix(threat_model): review fixes for IDs, strict mode, boundaries, and Rule callback

- Fix stride_threats/2 to use Map.put_new for IDs so custom rule IDs are preserved
- Add meta param to Rule.threats_for_flow/4 callback; custom rules can now inspect
  flow encryption, protocol, etc. (breaking behaviour change for implementers)
- Rename internal threats_for_flow/4 to default_threats_for_flow/4 to avoid naming
  collision with the callback
- Strip cluster_ prefix from boundary_of/2 and cross_boundary_flows/1 public API
- Fix crosses_boundary?/3 to return false when either side has no boundary,
  preventing false-positive cross-boundary alerts on unassigned elements
- Clean up add_typed_node to only include privilege/sensitivity/retention on
  relevant element types instead of nil-padding all nodes
- Add strict: mode to ThreatModel.new/1; data_flow/4 raises on missing endpoints
  when strict is true (consistent with Dependency/FSM/DT/MindMap)
- Fix risk_score/2 duplicate weight defaults via Keyword.merge
- Document attack_paths complexity and add :max_paths option
- Add public to_plantuml/2 delegation
- Document heatmap flow-threat exclusion, stride_threats ID ordering note,
  severity-elevation level requirement, and CVSS weight disclaimer
- Update validate/1 docstring to note unchecked conditions
- Polish livebook: remove section cruft, hex/local labels, Kino.Layout.tabs,
  dark theme actually uses :dark, GDPRRule uses threats_for_flow/4 with meta,
  consolidate sequence sections, fix theme list consistency

28 of 29 new or added lines in 2 files covered. (96.55%)

5154 of 5784 relevant lines covered (89.11%)

19.96 hits per line