rm-hull / dot-block / 27106074721

61%

Build Type

push

github

Committed by web-flow

Commit Message

fix: Add new POST /check endpoint (#147)

* fix: automated code generation from Gemini for #145

* chore: iterative updates from Gemini based on PR comment

I have completed the requested refactoring of the blocklist handlers.

### Changes Made:
1.  **New Routes Package**: Created `internal/routes/blocklist.go` and implemented `BlocklistHandler`.
2.  **Dependency Injection**: Moved the handler logic out of `BlocklistUpdater` and into `BlocklistHandler`, which takes a `*blocklist.BlocklistUpdater` as a dependency.
3.  **Validation Logic**:
    *   Added a check to ensure no more than 100 domains are present in the request list.
    *   Added validation for each domain using `dns.IsDomainName` to ensure they are valid FQDNs.
    *   Returns `400 Bad Request` with an appropriate error message if validation fails.
4.  **Application Wiring**: Updated `internal/app.go` to instantiate `BlocklistHandler` and wire it to the `/reload` and `/check` endpoints.
5.  **Cleanup**: Exported necessary fields in `BlocklistUpdater` and removed the old handler methods from the `blocklist` package.
6.  **Testing**: Updated `internal/check_test.go` to use the new `BlocklistHandler` and verified that all tests in `internal/...` pass.

All tests passed successfully.

* chore: iterative updates from Gemini based on PR comment

I have completed the requested changes to document and test the new management endpoints.

### Changes made:
- **`test.http`**: Added test cases for the `/check` endpoint, supporting both JSON array and plain text (newline-separated) request bodies.
- **`README.md`**: Added a new **Management API** section describing the `/metrics`, `/reload`, and `/check` endpoints, including their behavior and authentication requirements.

* chore: iterative updates from Gemini based on PR comment

I have implemented the requested changes to the `/check` handler to ensure that errors from the blocklist check are properly handled.

### Changes made:
1.  **Updated `Block... (continued)

Coverage Stats

52 of 89 new or added lines in 6 files covered. (58.43%)

7 existing lines in 1 file now uncovered.

1252 of 2053 relevant lines covered (60.98%)

837.3 hits per line