jhillyerd / enmime / 27103795997

86%

main: 86%

Pull #401

github

fix: assemble RFC 2231 multi-segment filename params with non-UTF-8 charsets

Go's mime.ParseMediaType only supports UTF-8 and US-ASCII in RFC 2231
charset-encoded continuation parameters. When a Content-Disposition header
uses a non-ASCII charset (e.g. EUC-KR) split across multiple filename*N*=
segments, stdlib discards all but the last successfully decoded segment,
producing a truncated filename.

Add assembleRFC2231Params in the mediatype package to detect continuation
parameters (name*N*= / name*N=), sort by segment number, concatenate the
percent-decoded bytes, convert from the declared charset to UTF-8 using
enmime's existing coding package, and replace the N-segment params with a
single RFC 2231 UTF-8 encoded parameter before passing to mime.ParseMediaType.

Fixes #109

93 of 107 new or added lines in 1 file covered. (86.92%)

3370 of 3900 relevant lines covered (86.41%)

4215.29 hits per line