azmaveth / ex_mcp / fd97953bf14ac558be3656e448c5e191b1e5ca2e

65%

Build Type

push

github

Committed by azmaveth

Commit Message

feat(acp)!: close spec-violation and bug-class gaps across protocol, adapters, client

Inventory pass against https://agentclientprotocol.com found 11 issues —
spec violations that broke cross-compatibility with other ACP libraries,
bug-class regressions (caller passes value, adapter returns :ok, wire
carries something different), and missing features. 15 spec-regression
tests added to pin each behavior; all green.

BREAKING:
- Protocol.encode_session_{new,load,resume} now require non-nil cwd
  (spec marks cwd as required for these methods). Callers passing nil
  now raise FunctionClauseError instead of silently producing off-spec
  requests.
- Client.{new,load,resume}_session/3-4 require non-nil cwd for the
  same reason.

Spec violations fixed:
- Protocol encoders no longer drop cwd when nil
- Claude/Codex no longer emit non-spec sessionUpdate:"usage" — token
  billing rides on the prompt response result's usage extension instead
  (spec's usage_update discriminator is for context-window fill, not
  input/output token counting)
- Codex session/set_mode actually persists modeId in state, and
  session/new forwards it as approvalPolicy on the wire so the three
  advertised modes (suggest/auto-edit/full-auto) finally do something
- PermissionOption.kind validated against the spec enum
  (allow_once|allow_always|reject_once|reject_always) in
  encode_permission_request

Bug class closed:
- Pi thinking_level invalid values now return {:error, reason, state}
  instead of silent {:ok, :skip, state} (caller gets JSON-RPC -32602
  via AdapterBridge's new error-synthesis path)
- Codex caller-supplied session/new params.model wins over state.model
  (was reversed)
- Claude session/prompt with image content blocks now forwards them
  using Anthropic Messages API content-block format; audio/resource
  blocks return {:error, ...} instead of silently dropping

Missing features:
- Protocol.encode_session_delete/1 added (gated by
  agentCapabilities.delete per spec)... (continued)

Coverage Stats

0 of 64 new or added lines in 6 files covered. (0.0%)

195 existing lines in 5 files now uncovered.

1434 of 16048 relevant lines covered (8.94%)

5.84 hits per line