ArduPilot / MethodicConfigurator / 27096287539

94%

push

github

fix(param-editor): guard against silent overwrite in connection rename refresh

Add conflict checks in `_refresh_current_step_connection_renames()` so that
a rename is skipped (with a warning) when `new_target` already exists in
`current_step_parameters` as an unrelated parameter, preventing silent data
loss on both the "target changed" and "new rename" branches.

Add six BDD-style unit tests in `TestRefreshConnectionRenames` covering:
- eval failure leaves state unchanged
- normal new rename applies correctly
- new rename skipped when target already exists (fix)
- rename undone when expression no longer applies
- rename retargeted when destination changes
- retarget skipped when new target already exists (fix)

1948 of 2020 branches covered (96.44%)

12425 of 13156 relevant lines covered (94.44%)

2.83 hits per line