vektah / gqlparser / 933

87%

push

circleci

fix: reject duplicate enum values and repeated non-repeatable directives (#436)

LoadSchema silently merged duplicate enum values (no uniqueness check),
unlike object fields which already error with "Field X.Y can only be
defined once." Add the equivalent check for enum values, reported as
"Enum value X.Y can only be defined once."

Also enforce that a non-repeatable directive is applied at most once per
schema location during schema validation (the executable-document rule
in validator/rules already covers queries, but the type system was
unchecked). The check is scoped to single authored locations via a
singleLocation flag: a type's own directives are merged across its base
definition and every extension, which the spec treats as distinct
locations, so the merged list is exempt to avoid rejecting a directive
used once per location.

Adds YAML cases covering duplicate enum values (same definition and
across an extension), a repeated non-repeatable directive on a field and
on an enum value, and positive cases (repeatable directive, the same
directive on distinct locations, and a directive on a type plus its
extension).

Fixes #435

Co-authored-by: Alexander Dvoretsky <alex.dvoretsky+catonian@catonetworks.com>

38 of 38 new or added lines in 1 file covered. (100.0%)

5092 of 5828 relevant lines covered (87.37%)

1.01 hits per line