dal-go / dalgo / 27058337672

100%

push

github

feat(dalgo2memory): recordset reader + e2e GROUP BY/column-projection coverage (#62)

* feat(dalgo2memory): implement recordset reader; e2e GROUP BY + column projection

dalgo2memory recordset path (crucial for DataTug):
- Implement ExecuteQueryToRecordsetReader on both *database and session,
  replacing the previous ErrNotSupported stub. It reuses the records pipeline
  (WHERE, GROUP BY, HAVING, projection, joins, ORDER BY, LIMIT/OFFSET) and
  pivots the resulting rows into a columnar recordset.
- Columns come from the query's explicit SELECT columns when present
  (projection / aggregation), else the sorted union of row keys (SELECT *).
  Values are stored in untyped (any) columns, matching the adapter's
  schemaless JSON storage. Keys-only rows expose the key under "ID"; struct
  bodies are converted via a JSON round-trip.
- 100% statement coverage retained.

end2end shared suite:
- Add GROUP BY (COUNT(*)/SUM + HAVING) and column-projection conformance tests,
  each exercised over BOTH read paths (records reader and recordset reader).
- Tests follow the capability-reporting convention: a query feature that an
  adapter does not implement returns dal.ErrNotSupported and the sub-test skips
  (via errors.Is), so adapters opt into coverage by implementing the feature.
- Wire the new sub-tests into queryOperationsTest; teach the mock-based
  TestEndToEnd to report the new shapes as unsupported.
- Document the capability-reporting approach in end2end/README.md.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* test(end2end): drop unreachable defensive branch to restore 100% coverage

Projected/aggregated records carry map data by contract, so readMapRecords
asserts map[string]any directly instead of via a recordDataAsMap helper whose
*map and default-error branches were unreachable in the conformance suite and
dropped module coverage to 99.9% (CI requires 100%).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
... (continued)

238 of 238 new or added lines in 4 files covered. (100.0%)

6402 of 6402 relevant lines covered (100.0%)

1.14 hits per line