accordproject / concerto-codegen / 27027887109

98%

push

github

fix(codegen): update Level enum to include NONE value and adjust JSON… (#243)

* fix(codegen): update Level enum to include NONE value and adjust JSON schema generation

- Added 'NONE' value to the Level enum in the model definition.
- Removed $id assignment for inlined map schemas to prevent conflicts in JSON schema generation.
- Updated related test snapshots to reflect changes in the Level enum.

Signed-off-by:  Apoorv <130035517+APOORV7G@users.noreply.github.com>
Signed-off-by: Apoorv <130035517+APOORV7G@users.noreply.github.com>

* test(codegen): add tests for non-empty and empty enum handling in JSON schema generation

- Introduced tests to verify the correct handling of non-empty enums, ensuring they emit valid values and compile with Ajv.
- Added a test to confirm that schemas with empty enums fail Ajv compilation as expected.
- Updated the JSON schema visitor to accommodate these new test cases.

Signed-off-by: Apoorv <130035517+APOORV7G@users.noreply.github.com>

* fix(codegen): handle empty enums in JSON schema generation

- Updated the JSONSchemaVisitor to correctly handle empty enums by using the 'not' keyword instead of an empty 'enum' array.
- rewrote tests to verify that schemas with empty enums compile successfully with Ajv.

Signed-off-by: Apoorv <130035517+APOORV7G@users.noreply.github.com>

---------

Signed-off-by: Apoorv <130035517+APOORV7G@users.noreply.github.com>

1628 of 1694 branches covered (96.1%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

3115 of 3132 relevant lines covered (99.46%)

9702.72 hits per line