stacklok / toolhive / 27023954418

66%

push

github

Domain-type the ElicitationRequester seam (#5456)

* Domain-type the ElicitationRequester seam

Replace composer.SDKElicitationRequester, which leaked mcp-go's
ElicitationRequest/ElicitationResult across the soon-to-be VMCP
boundary, with a domain-typed vmcp.ElicitationRequester interface and
ElicitationRequest/ElicitationResult value types that carry no mcp-go
types. This confines all mcp-go translation to the sanctioned adapter
(server/sdk_elicitation_adapter.go), closing anti-pattern #5 on the
elicitation path ahead of New(cfg) -> VMCP (#5437).

Implements changes for issue #5436:
- Add pkg/vmcp/elicitation.go with the domain interface and value types
  (form-mode only; no URL-mode fields)
- Retype DefaultElicitationHandler to the domain requester; security
  validation and the Content any->map assertion are unchanged
- Make sdkElicitationAdapter the sole domain <-> mcp-go translator, with
  an internal SDK seam so translation is unit-testable; copy Meta before
  NewMetaFromMap mutates it and omit _meta when nil
- Regenerate mocks under pkg/vmcp/mocks; drop composer/mocks

* Strengthen elicitation handler timeout and content tests

Addresses stacklok/toolhive#5456 review comments:
- MEDIUM elicitation_handler_test.go (3357216826): add accept case with
  non-map Content asserting it is treated as nil, covering the warn-log
  else branch the #5436 Testing Strategy requires
- MEDIUM elicitation_handler_test.go (3357216877): replace the weak
  timeout_capped_to_max table case with a dedicated test that captures
  the context deadline and asserts it is capped to maxElicitationTimeout,
  so the timeout-bomb protection is actually guarded

55 of 55 new or added lines in 3 files covered. (100.0%)

66461 of 100870 relevant lines covered (65.89%)

63.03 hits per line