kubeovn / kube-ovn / 27020761364

26%

Build Type

push

github

Committed by web-flow

Commit Message

perf(ovs): list NAT and static routes via single WhereCache scan (#6829)

* perf(ovs): list NAT and static routes via single WhereCache scan

Replace the per-UUID Get loop in listLogicalRouterNatByFilter and
listLogicalRouterStaticRoutesByFilter with a single WhereCache().List()
filtered by a UUID set, mirroring listLogicalRouterPoliciesByFilter and
batchListLogicalRouterStaticRoutesForDelete.

This drops the per-row context timeout allocation and the extra deep
clone done for every row, cloning only matched rows. Also removes the
now-unused GetLogicalRouterStaticRouteByUUID helper.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* perf(ovs): skip cache scan when router has no NAT or static routes

listLogicalRouterNatByFilter and listLogicalRouterStaticRoutesByFilter
now return early when lr.Nat / lr.StaticRoutes is empty, instead of
running a full WhereCache().List() scan that can never match. Routers
with no NAT or no static routes are common, so this restores the
immediate-return behavior of the old per-UUID loop and avoids an
O(table) cache scan on them.

Addresses Copilot review feedback on PR #6829.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* test(ovs): add benchmark comparing Get loop vs WhereCache list

Benchmark the NAT listing fast path against the previous per-UUID Get
loop on an identical in-memory NB cache, covering both the N~=T hot
path and the N<<T boundary case. Widen the newOVSDBServer and
newOvnNbClient test helpers to testing.TB so benchmarks can reuse them.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

---------

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

20 of 24 new or added lines in 2 files covered. (83.33%)

2 existing lines in 2 files now uncovered.

14870 of 57887 relevant lines covered (25.69%)

0.3 hits per line