KarpelesLab / libwallet / 27005237997

25%

Build Type

push

github

Committed by MagicalTux

Commit Message

device transfer: rename confirm/cancel endpoints to single-colon form + bump 0.4.52

The 0.4.51 session-lifetime fix was correct, but the user kept
getting LibwalletException(404): Not found on
confirmDeviceTransferExport — same symptom, different root cause.

apirouter and pobj disagree on where to split a multi-colon name:

- pobj.RegisterStatic splits at the FIRST ':' to find the object,
  so registering "Wallet:exportToDevice:confirm" stored the
  handler at Wallet/static["exportToDevice:confirm"].
- apirouter.Call splits the request path at the LAST ':' to find
  the method, so a call to "Wallet:exportToDevice:confirm"
  looked for Wallet:exportToDevice/static["confirm"].

Two different keys, lookup always missed, fs.ErrNotExist surfaced
as 404 "Not found". The endpoint has been structurally unreachable
since it was introduced — the earlier chain of bugs (transfer/<sid>
dispatch, e.Emitter vs BroadcastJson, registry-delete-on-claim)
kept the flow from ever reaching it, so the routing miss never
manifested until 0.4.51 cleared the last earlier blocker.

Rename Wallet:exportToDevice:confirm → Wallet:exportToDeviceConfirm
and same for cancel. Single colon → both libs agree on the split,
both store and look up at Wallet/static["exportToDeviceConfirm"].
Update the matching Dart callers in wallet_api.dart.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

15 of 0 new or added lines in 0 files covered. (NaN%)

120 existing lines in 1 file now uncovered.

4045 of 18460 relevant lines covered (21.91%)

101.36 hits per line