KarpelesLab / libwallet / 26993183602

22%

push

github

device transfer: keep session in registry through confirm window + bump 0.4.51

0.4.49's global dispatcher claimed sessions by deleting them out of
transferRegistry on handler entry — meant to race-protect concurrent
pair requests for the same sid. But apiWalletExportToDeviceConfirm
looks the session up in the same registry while the host runs its
biometric prompt; with the entry already gone, every confirm came
back as errTransferSessionNotFound — rendered to the Dart side as
`LibwalletException(404): Not found`. So 0.4.49 fixed dispatch +
0.4.50 fixed the event sink, but exportToDevice still couldn't
complete a transfer.

Refactor:

- transferHandle now looks up the session WITHOUT removing it.
  Race protection moves to a new `claimed bool` on the session,
  flipped under s.mu the first time a valid pair request arrives;
  subsequent invocations for the same sid see claimed=true and
  return session_not_found without racing on s.confirm / s.cancel.
- Defer removes the session from the registry when the handler
  fully exits (after confirm/decline/timeout), so the confirm path
  finds it during the whole 90-second confirm window.
- Existing 5-min cleanup ticker still backstops sessions whose
  defer was skipped (panic, process exit).

This was the last failure mode in the chain — 0.4.49 routed the
request, 0.4.50 forwarded the event, 0.4.51 keeps the session
alive long enough for the confirm to land.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

0 of 14 new or added lines in 1 file covered. (0.0%)

4032 of 18447 relevant lines covered (21.86%)

101.7 hits per line