26945958108
56%

Ran 04 Jun 2026 10:27AM UTC

Jobs 1

Files 25

Run time 1min

Badge

Embed ▾

Committed 04 Jun 2026 10:23AM UTC coverage: 56.136%. Remained the same

Build # 26945958108

Build Type

push

github

Committed by

web-flow

Commit Message

fix(disaggregatedset): tighten ForSingleActiveRevision waiter (#870)

ForSingleActiveRevision summed spec.replicas across all roles of a
revision and treated any revision with sum > 0 as active. Two escape
windows let the waiter return before the rollout was actually settled:

1. Mid-rollout: during coordinated drain the new revision briefly has
   one role scaled up (e.g. prefill=1, decode=0). The waiter accepted
   it and the next assertion reported the revision as orphaned.

2. Apply-but-not-reconciled: immediately after kubectl apply, only the
   old revision exists with all roles > 0. The revision-agnostic check
   accepted that as a single active revision before the controller had
   even created the new revision.

Track per-revision how many role LWS still have replicas=0, and thread
the old revision through the waiter so it must be drained before
declaring the rollout settled. Extract the predicate as
evalSingleActiveRevision and add unit tests covering the snapshot
classes.

The waiter copy under disaggregatedset/test/utils/kubectl/waiters.go
is left untouched; that folder is dead code, removed as part of the
disaggregatedset relocation. Supersedes the previous attempt.

Signed-off-by: Kay Yan <kay.yan@daocloud.io>

Coverage Stats

2150 of 3830 relevant lines covered (56.14%)

46.09 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	26945958108.1	04 Jun 2026 10:26AM UTC	25	56.14	GitHub Action Run

kubernetes-sigs / lws / 26945958108
56%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 26945958108

kubernetes-sigs / lws / 26945958108 56%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 26945958108

kubernetes-sigs / lws / 26945958108
56%

README BADGES
x