tarantool / tarantool / 26944036069
88%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 525
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 87.691% (-0.008%) from 87.699%
26944036069

push

github

sergepetrenko 
box: rotate and put xlogs into backup

If backup is done with latest checkpoint we rotate current xlog and add
all xlogs after snapshot to the list of backup files.

Make sure every statement from rotated xlog is committed in replica set.
If some statement is not committed then it can be rolled back later. In
this case in backup we have not committed statements. On restore these
statements can be committed, in particular if replica set is restored
from backup of single replica the statemement will be committed for
sure. So after restore we get database state that never existed in
original database.

Timeout for committing is box.cfg.replication_synchro_timeout. The
timeout is added to common code, so that snapshot/join can fail
on same timeout if txns in checkpoint are not committed in replicaset
in time.

I also added a latch to box_backup_start()/box_backup_stop() so they
won't run concurrently. box_backup_start() may yield, so
box_backup_stop() can step in and unref the checkpoint. This alone is
not a big deal though. But in case of error we will try to unref NULL
checkpoint and will get a crash.

Part of #11729

NO_CHANGELOG=will be added later
NO_DOC=will be added later

70800 of 119061 branches covered (59.47%)

59 of 63 new or added lines in 3 files covered. (93.65%)

47 existing lines in 16 files now uncovered.

106446 of 121388 relevant lines covered (87.69%)

1372222.47 hits per line

Uncovered Changes

Lines Coverage ∆ File
2
91.37
 0.17% src/box/box.cc
1
97.37
 3.17% src/box/checkpoint.c
1
90.19
 0.16% src/box/wal.c

Coverage Regressions

Lines Coverage ∆ File
7
85.51
 -0.49% src/box/xlog.c
6
95.22
 -1.25% src/box/vy_read_iterator.c
5
90.3
 -0.39% src/box/vy_log.c
4
96.95
 -0.41% src/lib/msgpuck/msgpuck.h
4
81.82
 -12.12% src/lua/minifio.c
3
89.64
 -0.22% src/box/applier.cc
3
88.09
 -0.19% src/box/vy_run.c
3
92.86
 -0.28% src/lib/core/fiber.c
2
96.3
 -3.7% src/lib/core/backtrace.c
2
82.22
 -4.44% src/lib/core/latch.h
2
80.95
 -9.52% src/lib/core/tt_sigaction.c
2
95.45
 -4.55% src/lib/json/json.h
1
94.64
 -0.12% src/box/tuple_format.c
1
90.19
 0.16% src/box/wal.c
1
91.68
 0.0% src/lib/swim/swim.c
1
75.85
 -0.24% src/main.cc
Jobs
ID Job ID Ran Files Coverage
1 26944036069.1 525
87.69
 GitHub Action Run
Source Files on build 26944036069