KarpelesLab / libwallet / 26939167125

22%

push

github

device transfer: register handler under bare "transfer" segment + bump 0.4.49

The 0.4.48 waitOnlineSpot fix proved Spot was online on both ends, yet
pair_received still never fired. Root cause: spotlib's dispatcher
(connect.go:317-336) only matches the first path segment after the
recipient id, but exportToDevice registered the per-session handler
under "transfer/<sid>". The lookup always missed; the receiver hung
the full transferQueryTimeout (2 min) before giving up.

Refactor:

- One permanent global handler, installed in InitEnv under the bare
  "transfer" prefix (same single-segment shape pair.go uses). No more
  per-session SetHandler/SetHandler(nil) churn.
- transferQueryBody gains a Sid field. Receiver builds target as
  <spotID>/transfer and puts the sid in the body.
- transferHandle (now func(env, msg)) claims the matching session
  out of transferRegistry under one lock per request — concurrent
  duplicate requests for the same sid resolve cleanly as
  session_not_found instead of racing on the channels.
- Comment + endpoint constant updated to reflect the new shape.

Hosts on 0.4.48 will keep seeing peer_unreachable until both ends are
on 0.4.49 — bump together.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

0 of 50 new or added lines in 2 files covered. (0.0%)

4031 of 18420 relevant lines covered (21.88%)

102.57 hits per line