sgerrand / git_hoox / 26939093518

98%

push

github

refactor(hook): tighten run/2 return contract

t:GitHoox.hook_result/0 advertised :skip as a valid hook return, but
:skip was actually an internal Runner signal (now its own telemetry
event) — a custom hook returning it would silently fall through
Runner.maybe_restage/2 as success without re-staging or being counted.
Drop :skip from the public type, make maybe_restage/2 total with
explicit clauses for :ok, {:ok, [path]}, and {:error, _}, and update
GitHoox.Hook docs so authors know they get a hard FunctionClauseError
if they return anything else. Runner now normalises both :ok and
{:ok, []} to the same outcome shape.

2 of 2 new or added lines in 1 file covered. (100.0%)

583 of 593 relevant lines covered (98.31%)

27.6 hits per line