sds / mock_redis / 26936466164

98%

push

github

[Feature] Add gt option for zadd method at sorted set (#344)

Hi there, I am using `mock-redis` for our app's test environment. We are
looking to leverage `zadd` with the `gt` option from Redis for a caching
use case. I found out that `mock-redis` does not implement the `gt`
option for `zadd` the moment and took sometime to implement it in my
fork.

I implemented the `gt` option to `zadd`, having referred to the current
official [documentation](https://redis.io/docs/latest/commands/zadd/)
and used a couple of AI conversations to get an understanding of the
various edge cases before adding and committing the code in.

I've also validated that invocation of `zadd` with `gt` option does work
accordingly in the new specs added in the feature branch that I'm
developing right now.

# Changes

1. Add support for `gt` for single member and multi member `zadd` usages
2. Raise command error when both `gt` and `nx` options are included in
the same `zadd` invocation.
3. Support `gt` usages together with `xx` option, moving the branches
handling `nx` and `xx` downwards, respecting the current code structure.
4. Add support for `incr` option while using the `gt` option in both
single and multi member `zadd` invocation.

# Test

1. Multiple `it` blocks covering the changes and edge cases when any of
`gt`, `xx` and `nx` are included.

---

Hope you can take sometime to review and let me know what changes might
be desired for this to get merged. 🙏

28 of 28 new or added lines in 1 file covered. (100.0%)

1949 of 1985 relevant lines covered (98.19%)

1655.28 hits per line