sixcolors / cs50-final-project / 26925788527

99%

push

github

Fix broken data sources and update geocoder (#541)

* Fix broken data sources and update geocoder

- Replace decommissioned CWFIS CSV endpoint with WFS endpoint
  (geoserver.cwfif.nrcan.gc.ca/geoserver/wfs) in Map.svelte;
  update field names to match WFS response schema and add
  response.ok guard to prevent parsing error HTML as CSV
- Replace broken NRCAN Geolocation Service (HTTP 500 on all
  browser cross-origin requests) with OpenStreetMap Nominatim
  in Locator.svelte; simplify response handling (lat/lon strings,
  no type/qualifier filtering needed)
- Update tests/locator.test.ts fetch mock for Nominatim format
- Update README and App.svelte to reflect new data sources
- Fix @rollup/plugin-terser CVE (package.json/package-lock.json)

* Update snapshot for App.svelte Nominatim link change

* Address PR review comments

- Locator.svelte: add response.ok checks in filterLocations and
  submitValue; add isFinite guard on lat/lon before dispatching
- Location.svelte: replace {@html itemLabel} with {itemLabel} to
  eliminate XSS vector from external geocoder display_name values
- Map.svelte: add escapeHtml helper and escape all external values
  in bindPopup HTML; switch WFS outputFormat from csv to
  application/json to avoid fragile split(',') CSV parsing; update
  data parsing to use GeoJSON FeatureCollection features; add
  .catch() to wildfire fetch chain; update stale CSV comment
- tests/locator.test.ts: add ok/status to fetch mock; replace fixed
  setTimeout sleeps with screen.findByText and waitFor
- README.md: remove stale NRCAN Open Data API reference in
  description

* chore: exclude build artifacts and entry point from coverage

* Address second round of PR review comments

- Map.svelte: fix misleading popup label ('Started on' -> 'Last
  reported:' since situation_report_date is a report date not fire
  start date); add geometry.coordinates fallback for lat/lon in case
  WFS properties lack those fields
- Locator.svelte: return early in... (continued)

16 of 23 branches covered (69.57%)

Branch coverage included in aggregate %.

81 of 81 new or added lines in 4 files covered. (100.0%)

945 of 945 relevant lines covered (100.0%)

1.01 hits per line