• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

k8snetworkplumbingwg / multus-cni / 26907881970
50%
master: 50%

Build:
Build:
LAST BUILD BRANCH: refs/tags/v4.3.0
DEFAULT BRANCH: master
Ran 03 Jun 2026 07:32PM UTC
Jobs 1
Files 27
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

03 Jun 2026 07:26PM UTC coverage: 50.307% (+0.06%) from 50.248%
26907881970

Pull #1483

github

bpickard22
Fix certificate rotation race condition in per-node certificates

Handle transient certificate errors during daemon startup to prevent
crash-loops when pods restart during the certificate rotation window
(~3 seconds) where the symlink is temporarily removed or the file is
empty.

Changes:
- Add isTransientCertError() to classify errors as transient vs permanent
  using string matching (the cert store wraps errors with %v, destroying
  type information, so errors.As is ineffective here)
- Use errors.As for NoCertKeyError (returned directly, not wrapped) and
  retry it in the poll callback since it is expected during initial
  provisioning and during rotation when the symlink is briefly removed
- Transient errors (file not found, empty/invalid PEM) return (false, nil)
  in the existing 1-second poll, retrying naturally
- Permanent errors fail fast via (false, err) instead of polling for the
  full 2-minute timeout
- Add unit tests for isTransientCertError covering all error cases

Assisted by Claude Opus 4.6

Signed-off-by: Benjamin Pickard <bpickard@redhat.com>
Pull Request #1483: Fix certificate rotation race condition in per-node certificates

15 of 27 new or added lines in 1 file covered. (55.56%)

2543 of 5055 relevant lines covered (50.31%)

6.29 hits per line

Uncovered Changes

Lines Coverage ∆ File
12
19.07
6.13% pkg/k8sclient/kubeconfig.go
Jobs
ID Job ID Ran Files Coverage
1 Go- - 26907881970.1 03 Jun 2026 07:32PM UTC 27
50.31
GitHub Action Run
Source Files on build 26907881970
  • Tree
  • List 27
  • Changed 1
  • Source Changed 0
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Pull Request #1483
  • PR Base - master (#26644984856)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc