opendefensecloud / solution-arsenal / 26894448077

74%

Build Type

push

github

Committed by web-flow

Commit Message

fix: gracefully handle non-ocm repositories (#573)

## What
<!-- One sentence summary -->
Closes #535

## Testing

reproduced error as described via:

```bash
make dev-cluster
kubectl port-forward -n zot svc/zot-discovery 5000:443 &
kubectl apply -n solar-system -f test/fixtures/e2e/zot-discovery-registry-scan.yaml
docker pull nginx:latest
docker tag docker.io/library/nginx:latest localhost:5000/nginx:latest
docker push localhost:5000/nginx:latest
kubectl rollout restart deployment -n solar-system solar-discovery
kubectl logs -n solar-system deployments/solar-discovery
# verbose errors

git checkout fix/535-non-ocm-discovery-errors
make dev-cluster-rebuild
kubectl rollout restart deployment -n solar-system solar-discovery
kubectl logs -n solar-system deployments/solar-discovery
# 1 debug line per skipped ocm repo
```

Unit tests were added as well.

## Checklist
- [x] Tests added/updated
- [x] No breaking changes (or upgrade path documented above)
- [x] Readable commit history (squashed and cleaned up as desired)
- [x] AI code review considered and comments resolved

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Improved error logging during repository scanning to reduce noise;
repositories that don't match the expected format now log at verbose
level instead of error level, making scan logs clearer.

* **Tests**
* Added comprehensive test coverage for repository parsing and error
handling scenarios.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Coverage Stats

9 of 9 new or added lines in 2 files covered. (100.0%)

4 existing lines in 2 files now uncovered.

2464 of 3384 relevant lines covered (72.81%)

57.65 hits per line