daycry / jobs / 26894196998

89%

push

github

fix: wire idempotencyKey through the envelope + remove the dead cron gate (#3)

Two functional defects surfaced by the v3 documentation audit.

1. idempotencyKey was inert on the dispatch path. EnvelopeFactory::toWire()
   never serialised the definition's idempotencyKey onto the wire, yet
   QueueWorker reads $wire->idempotencyKey to drive IdempotencyGuard — so
   builder-dispatched jobs were never deduplicated. toWire() now emits the key
   and canonicalJson() includes it in the signed identity fields (tampering
   with the dedup key to suppress a legitimate run now fails verification).

2. jobs:cronjob:run was a no-op out of the box. CronRunCommand short-circuited
   via a global jobs_active cache flag that no v3 command ever set (the
   jobs:cronjob:enable/disable commands were removed). The runner returned
   SUCCESS without evaluating the schedule. Remove the vestigial gate so the
   command always evaluates the schedule; per-job control stays in the
   definition (enabled()/environments()). Drop the now-dead enable/disable/
   isActive/tryToEnable/alreadyEnabled/alreadyDisabled helpers from
   BaseJobsCommand.

Tests: add EnvelopeFactory propagation + signature coverage and an end-to-end
QueueWorker regression (idempotencyKey from definition -> skipped-idempotent);
rewrite CovCronRunCommandTest for the no-gate behaviour. Full suite green
(360 tests); PHPStan/Psalm/Rector/CS clean.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

19 of 19 new or added lines in 1 file covered. (100.0%)

1468 of 1652 relevant lines covered (88.86%)

7.65 hits per line