datatug / datatug-cli / 26886208568

62%

Build Type

push

github

Committed by web-flow

Commit Message

feat(filestore): persist DB models on save + make collection keys serializable (#140)

`SaveProject` previously logged "Saving N DB models IS NOT IMPLEMENTED YET"
and dropped the scanned schema. It now persists DB models via the existing
fsDbModelsStore, so `datatug scan` writes the tables/columns to disk
(e.g. dbmodels/<id>.dbmodel.json).

Wiring that revealed a deeper bug: DBCollectionKey kept its identity in
UNEXPORTED fields (schema/catalog/type) plus a dal.CollectionRef with no
exported fields, so a table/view serialized to `{"Ref":{}}` — losing its
name on round-trip. Fix: expose the identity as json-tagged fields
(Name/Schema/Catalog/Type), with Ref kept in-memory only (json:"-").

The field rename was done with `gopls rename` (type-aware) for the
method->temp step, then a safe grep for the unique temp -> field access,
so the ~190 call sites changed deterministically. Methods Name()/Schema()/
Catalog()/Type() are gone in favour of the fields.

Also: loadTable now applies the path-derived identity AFTER reading the
file body, so the directory-tree format (name in path) still wins and old
files without a body name keep loading.

Verified end-to-end: scanning the chinook SQLite fixture writes a dbmodel
with 11 named tables, their column lists, types and PKs. Added a
SaveProject round-trip test (table + column survive save/load). Full
module build, vet, and test suite pass.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

51 of 69 new or added lines in 14 files covered. (73.91%)

31 existing lines in 2 files now uncovered.

5497 of 14295 relevant lines covered (38.45%)

0.45 hits per line